Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/robot fixes #1075

Merged
merged 55 commits into from
Feb 5, 2025
Merged

Feat/robot fixes #1075

merged 55 commits into from
Feb 5, 2025

Conversation

cremebrule
Copy link
Contributor

No description provided.

@cremebrule cremebrule requested a review from ChengshuLi January 8, 2025 02:14
pre-commit-ci bot and others added 20 commits January 8, 2025 02:14
# Conflicts:
#	omnigibson/examples/robots/curobo_example.py
#	omnigibson/robots/manipulation_robot.py
#	tests/test_curobo.py
# Conflicts:
#	omnigibson/action_primitives/starter_semantic_action_primitives.py
#	omnigibson/configs/tiago_primitives.yaml
#	omnigibson/envs/data_wrapper.py
#	omnigibson/examples/robots/curobo_example.py
#	omnigibson/robots/fetch.py
#	tests/test_curobo.py
Copy link
Member

@ChengshuLi ChengshuLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments, looks great overall! Thanks!

omnigibson/robots/a1.py Outdated Show resolved Hide resolved
omnigibson/robots/franka.py Outdated Show resolved Hide resolved
omnigibson/robots/franka.py Show resolved Hide resolved
omnigibson/robots/franka_mounted.py Outdated Show resolved Hide resolved
omnigibson/robots/franka_mounted.py Outdated Show resolved Hide resolved
omnigibson/robots/stretch.py Outdated Show resolved Hide resolved
tests/test_controllers.py Outdated Show resolved Hide resolved
omnigibson/robots/manipulation_robot.py Outdated Show resolved Hide resolved
omnigibson/robots/manipulation_robot.py Outdated Show resolved Hide resolved
omnigibson/robots/manipulation_robot.py Outdated Show resolved Hide resolved
cremebrule and others added 18 commits January 28, 2025 18:29
…ardcoded finger properties from robot model classes
Copy link
Member

@ChengshuLi ChengshuLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some minor comments, happy to discuss in person!

omnigibson/controllers/ik_controller.py Show resolved Hide resolved
omnigibson/objects/controllable_object.py Show resolved Hide resolved
omnigibson/utils/transform_utils_np.py Show resolved Hide resolved
omnigibson/utils/usd_utils.py Outdated Show resolved Hide resolved
@cremebrule cremebrule merged commit 1436f73 into og-develop Feb 5, 2025
22 checks passed
@cremebrule cremebrule deleted the feat/robot-fixes branch February 5, 2025 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants